Skip to content

Conversation

@patrickmoore-nc
Copy link
Contributor

@patrickmoore-nc patrickmoore-nc commented Jun 4, 2025

Description

Several module enhancements required for the Service Layer infrastructure deployment:

  • Function App module no longer requires a dedicated User Managed Identity for container retrieval from ACR (to support GitHub Container Registry).
  • Function App resource now ignores all tags - can't be selective here unfortunately - to prevent Terraform removing on every plan the hidden-link: tagging created automatically by AzureRM (e.g. for Application Insights linkage).
  • Storage Account module can now create Storage Queues as required.

Linked to:

Other minor changes:

  • Small update to ACME Certificate module documentation.
  • Regenerated all terraform-docs automatic documentation for the modules, which has captured some additional drift.
  • Cosmetic fix to the output of get-docker-names.sh script where filesystem changes in the sources folder don't match a specific package in compose.yaml. Previously the entire list was output as a single string so only the first item was indented with -, now list items will be indented consistently as per the other console output text.
  • Small simplification to the aggregate-reports job in the stage-3-build.yaml workflow template.

Testing

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@patrickmoore-nc patrickmoore-nc force-pushed the feat/DTOSS-9131-deploy-Service-Layer-infra-rebase branch 2 times, most recently from 44bcd5a to f9209f0 Compare June 4, 2025 14:06
@patrickmoore-nc patrickmoore-nc marked this pull request as ready for review June 4, 2025 14:11
@patrickmoore-nc patrickmoore-nc force-pushed the feat/DTOSS-9131-deploy-Service-Layer-infra-rebase branch from 318954a to 19033d1 Compare June 4, 2025 14:37
@patrickmoore-nc patrickmoore-nc force-pushed the feat/DTOSS-9131-deploy-Service-Layer-infra-rebase branch from 19033d1 to 5f2d9f4 Compare June 4, 2025 14:59
@patrickmoore-nc patrickmoore-nc added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit cf5e22f Jun 4, 2025
@patrickmoore-nc patrickmoore-nc deleted the feat/DTOSS-9131-deploy-Service-Layer-infra-rebase branch June 4, 2025 16:33
@patrickmoore-nc patrickmoore-nc changed the title feat: Terraform module changes for Service Layer infra feat: DTOSS-9131 Terraform module changes for Service Layer infra Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants